Prevent scrolling to bottom when selecting files #1222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #1193
When selecting a file using either the mouse or the
select
command, the cursor scrolls to the bottom as a result of calling thedir.sel
function.I don't think it's a good idea to change how the scrolling works for
dir.sel
- it's useful for forcibly setting the position of the cursor (to the bottom) without taking into account of it's original position (this prevents the cursor from ending up out of bounds if the number of files changes, e.g. by applying a filter). Instead, the code for selecting a file is changed to usenav.move
to achieve smoother scrolling similar to #1196.