Refactor pager commands & synchronous shell commands (no-op) #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
changed the title
joelim-work
reviewed
May 14, 2023
There was a problem hiding this comment.
Thanks very much for working on this @ilyagr!
I have left a few minor comments, but I think this PR is actually quite good already. In my opinion there is no need to make the code perfect here, and further refactoring work can alwasy be done later.
…cation This is meant to be straightforward and clearly a no-op,\ at the cost of being a bit verbose.
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
May 14, 2023
After the previous refactors, the logic for async shell commands can be simplified somewhat. There is likely room for further improvements, but that is beyond the scope of this PR.
|
Thanks for looking this over! |
joelim-work
approved these changes
May 14, 2023
|
Thanks @ilyagr for the patch and @joelim-work for the review. |
|
Thanks for reviewing, @gokcehan @joelim-work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to not cause any changes to functionality. It is the follow-up to #1201 and cleans up #1146.
It's designed to be reviewed commit-by-commit (though feel free do do whatever works for you). The first commit includes the changes I suggested in #1146 and #1152, the following commits are a slightly more extensive deduplication of functionality.