Added autocompletion and a simple lfcd script for nushell. #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelim-work
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Thanks for working on this. From what I can see, there has historically been very little support for nushell if any at all, so this will be a nice addition.
I have left a few comments that you might want to address. As a disclaimer, I have never used nushell before, and I really only have a few hours' worth of experience, so feel free to correct me on anything.
joelim-work
reviewed
Jul 14, 2023
joelim-work
approved these changes
Jul 14, 2023
|
LGTM. Thanks @mauerlaeufer for the patch and @joelim-work for the review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried following the same format as the preexisting files in the ./etc folder. Furthermore I only translated the existing script to the nu language. There might be nu-specific optimizations that I didn't consider. The code should speak for itself, I tested it with nu version 0.82.0 and lf version r30 and everything seems to work.