Improve refreshing of file statinfo #1536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found a bug where the file statinfo doesn't update when using
:cd
to change to a new directory that has not already been loaded bylf
. The issue happens because of the following checkif app.ui.msg == ""
which occurs when loading directories asynchronously:lf/app.go
Lines 407 to 409 in d8b7df8
This check comes from #994, where the intention was that asynchronous reloads should update the file statinfo, but also not overwrite error messages.
I have added a new variable
ui.msgIsStat
to track whether the statline is showing file statinfo or anecho
/echoerr
message, and changed the check to use this variable instead, which should fix the above issue. This also means the workaround in #1149 is not needed anymore.