-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lf.zsh
: make completions complete both lf
and lfcd
#1564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR.
I think it's actually fine to just add the lfcd
completion in lf.zsh
where the completion for lf
is. This is how it's done for lf.bash
:
Line 34 in f8399eb
complete -o filenames -F _lf lf lfcd |
@joelim-work suggested a better idea: to make `lf.zsh` complete both `lf` and `lfcd` This reverts commit c28393d.
This is an awesome idea, thank you for the tip. Could you please check if this change works for you? It does for me, but to be honest I'm not that well-versed with ZSH's completions system. |
lfcd
in ZSHlf.zsh
: make completions complete both lf
and lfcd
@postsolar Thanks, I have tried it and it works for me. I have given my approval. |
The following is unrelated, but I'm not sure if the
However
You can try it out if you want, but if you don't want to or don't have time, I'll look into it later. |
Actually I think it's fine to merge this as this is just about adding completion for |
Added a short comment on how to make
lfcd
complete CLI options and filepaths just aslf
itself in ZSH.Initially I had in mind splitting
lfcd.sh
into a new ZSH-specific file which would define shell completions forlfcd
but then I realized it might be more simple to just leave a note on how a user could do it themselves. Let me know if the initial idea is preferred.