Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories added to dirChan no longer trigger checkDir #1607

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

Michael-Gallo
Copy link
Contributor

In certain conditions, checkDir would cause a directory to be sent to app.nav.dirChan which would in turn call checkDir, creating an infinite loop. The call to checkDir when a value is sent to app.nav.dirChan is likely unnecessary and removing it should fix the loop
See Issue #1543

@joelim-work
Copy link
Collaborator

Thanks, I would also consider removing the following two lines of code since they were also introduced in the same commit, and is also a potential source for infinite loops:

lf/app.go

Lines 419 to 420 in cf99626

app.nav.checkReg(r)

@Michael-Gallo
Copy link
Contributor Author

Makes sense, done

@gokcehan
Copy link
Owner

@joelim-work @Michael-Gallo Is this waiting for my approval? Sorry, if that's the case. I think it looks fine and we can merge it.

@gokcehan gokcehan merged commit 951795c into gokcehan:master Mar 24, 2024
4 checks passed
@gokcehan gokcehan mentioned this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants