avoid using the user.Current on windows to avoid slow startup #1617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is domain joined, it can experience slow startups (aprox. 4-5 seconds, sometimes longer). After some investigation it seems that
user.Current()
makes a request to get the user info from active directory which will time out, and then it will fallback on the local info.this articles gives a very good example with docker commands.
https://www.fearofoblivion.com/slow-docker-commands-on-domain-joined-pc
I also used
process explorer
and find the same event on thelf.exe
process taking long time and failing withBAD NETWORK PATH
.This fix uses the
user.UserHomeDir()
andos.Getenv("USERNAME")
to get the user details which will get them directly from the environment and solves the issue.