Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on-quit when terminal closes #1681

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Run on-quit when terminal closes #1681

merged 1 commit into from
Apr 7, 2024

Conversation

joelim-work
Copy link
Collaborator

@joelim-work joelim-work commented Apr 6, 2024

Move on-quit hook command to inside app.quit so that it is executed even when terminated via a signel (e.g. terminal is closed). Based on #847 (comment).

@gokcehan gokcehan merged commit ce12116 into gokcehan:master Apr 7, 2024
4 checks passed
@joelim-work joelim-work deleted the on-quit branch April 8, 2024 00:10
@joelim-work joelim-work added the fix Pull requests that fix existing behavior label Jun 24, 2024
@joelim-work joelim-work added this to the r33 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix existing behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on-quit command is not run when terminal is closed
2 participants