-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to hide listBinds when pressing keys #1815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution.
This sounds like a reasonable feature to add, and the changes looks good overall. I was just wondering whether it makes sense to call the option showbinds
instead. To me, the word 'draw' indicates that the option is used when actually drawing the UI (as part of ui.draw
). This is a minor point though.
I was thinking about the name of the option as well. Since the function in Do I need to submit another commit with changes here or open a new one? |
I would say that the convention is to keep the option name as concise as possible, without being too ambiguous in its meaning. In the context of file managers, the meaning of So For the PR itself you can just keep adding new commits, no need to force-push. All the commits will be squashed into a single commit anyway when merging to the master branch. |
I chose to go with (And i'm not sure why but my editor keeps changing other lines in the file, like urls you see in diff files? Maybe something to do with indentation, sorry if this is inconvenient) |
You must have your text editor configured to somehow delete The rest of the changes look fine, so if you can fix the line endings then I will approve the PR. |
Should be done now I think, just did |
Just out of interest, how did you add the |
Actually it's probably fine I can fix it myself. Will merge it now then. Thanks once again. |
Hello, I wanted to make an option that hides the bindings popup that shows up every time you press some sequence of keys.
Why? Because it can obstruct some files at the bottom of the screen.
And moreover the pressed keys are already shown by default if "rulerfmt" has
%a
expansion (as seen on the screenshots below, on bottom right of my window, when I pressg
)Here is example, when the new
drawbinds
option is set to true (that is, by default)And here is after, when the
drawbinds
option is set to false, and pressed any key