-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show symlink destination #374
Conversation
@wedens Thank you very much for the patch. This has been missing for quite a while and I'm glad it is finally getting implemented. I have tried the patch and it seems to be working great. A minor nitpick in the code is that you seem to ignore the error returned by |
It seems to fail on invalid path or if it's not a symlink. Those conditions are already checked before
I've added those changes. I'm not a Go developer, so I wasn't sure what's the best practice for unlikely errors ;) |
@wedens Seems good to me, thanks again. |
Fix colour construction issue This also has a test to mitigate it in the future Remove `colormode` option The original issue it was trying to solve is no longer present with tcell (it being a holdover from `color256` on termbox) so it is not needed. retire gitter channel in favor of irc/matrix Export options as environment variables (gokcehan#448) * Export options as environment variables Any options from gOpts are available via lf_OPTION environment variables. For now it works only on booleans, integers and strings (no array support) * Do not export some of the options * Add support for arrays and fix numbers * Fix comments * Replace 1 and 0 with true and false * Export hidden,reverse,dirfirst and sortby options * Fix comments * Little fix * Simplify boolean conversion log readlink errors instead of fail Related gokcehan#447 and gokcehan#374
Fix colour construction issue This also has a test to mitigate it in the future Remove `colormode` option The original issue it was trying to solve is no longer present with tcell (it being a holdover from `color256` on termbox) so it is not needed. retire gitter channel in favor of irc/matrix Export options as environment variables (#448) * Export options as environment variables Any options from gOpts are available via lf_OPTION environment variables. For now it works only on booleans, integers and strings (no array support) * Do not export some of the options * Add support for arrays and fix numbers * Fix comments * Replace 1 and 0 with true and false * Export hidden,reverse,dirfirst and sortby options * Fix comments * Little fix * Simplify boolean conversion log readlink errors instead of fail Related #447 and #374
Closes #196.
Shows symlink destination at the bottom, at the right of permissions/size/time.
If it's a symlink to a symlink, it'll resolve only the first one, which I think makes sense.
I've also tried adding "target" option to
info
, but fairly long info strings are not being displayed at all. Even when there is a lot of space.PS: this is my first ever code in Go 🙂