Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a selection mode #849

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Add a selection mode #849

merged 1 commit into from
Oct 15, 2022

Conversation

laktak
Copy link
Contributor

@laktak laktak commented Jun 1, 2022

When working with lf I prefer to have it use only the selections I made in the current directory.

    selmode        string    (default 'all')

Selection mode for commands.
When set to 'all' it will use the selected files from all directories.
When set to 'dir' it will only use the selected files in the current directory.

Use case: I often forget to clear selections before selecting files in the current directory and have to start over or (worst case) deleted some files by mistake.

@laktak laktak mentioned this pull request Jul 4, 2022
@rafcon-dev
Copy link

This is sorely needed, I just tested this, wasn't even aware of this weird behaviour, selection mode should be 'dir' by default indeed. This can really lead to some really nasty surprises.

@laktak
Copy link
Contributor Author

laktak commented Aug 23, 2022

@rafcon-dev as I understand it gokcehan is busy with things in real life ... just fyi because I saw you commented on other issues as well.

@rafcon-dev
Copy link

Thank you for the fyi mate. Yeah, such is life indeed, hopefully they'll find some time once things are sorted out!

@laktak
Copy link
Contributor Author

laktak commented Oct 10, 2022

Responding to #950

@gokcehan Selection mode in #849 has been quite fundamental to lf so far so I fear it might double our reported issues somehow.

I don't quite understand that connection. Are you talking about users not understanding the option? It's off by default.

@gokcehan
Copy link
Owner

@laktak Thanks for the patch.

@gokcehan gokcehan merged commit 21a32a7 into gokcehan:master Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants