Fix user query when using libc implementation of os/user #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ilyagr
reviewed
Oct 18, 2022
| @@ -66,10 +66,14 @@ func init() { | |||
| if err != nil { | |||
| log.Printf("user: %s", err) | |||
There was a problem hiding this comment.
Could you add a comment here, something along the lines:
// When the user is not in /etc/passwd (for e.g. LDAP) and CGO_ENABLED=1 in go env,
// the cgo implementation of user.Current() fails even when HOME and USER are set.
GaetanLepage
force-pushed
the
fix-user-query
branch
from
4ffe1c4 to
347b519
Compare
|
@GaetanLepage Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
In the case where the user is not in
/etc/passwd(for e.g. LDAP), the cgo implementation ofos/userwhich uses thelibcfunctions is not able to find the user name and home directory.This fix implements a fallback that uses the
$USERand$HOMEenvironment variables.Note: This problem does not occur when using the pure go implementation of
os/user(for e.g. when specifyingCGO_ENABLED=0) which already implements the same kind of fallback.