When clicking on file preview, only open files on right-click (+ doc fix) #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when mouse is on, I often click on the preview accidentally since it's such a large target. Moreover, there is very little space I can click without having the `lf` state change drastically (since I must click on the current file for the preview to stay the same). This commit prevents that.
Currently, the example fails confusingly for newer versions of `tput`. See gokcehan#718.
ilyagr
changed the title
|
Fine by me. Works the same in ranger. |
gokcehan
added a commit
that referenced
this pull request
Nov 13, 2022
|
@ilyagr Issue link in the example was bugging me so I have now added env variables to be used in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #963, when the mouse is on, I often click on the preview accidentally since it's such a large target, which takes me to another program. Moreover, if the terminal with
lfisn't focused and a file is previewed, there is very little space where I can click without having the state change drastically (clicking the preview is out, clicking almost anywhere else changes the preview).This commit fixes the issue, at the cost of the ability to open files with the mouse becoming slightly harder to discover.
I hope you're OK with this, @p-ouellette. An alternative I considered would be to create a special command
preview-left-clickthat could default to something like:echo Right-click to open filebut could be changed toopen(or vice versa), but I'm not sure that's worth it.P.S. I also included a separate minor fix to the docs related to #718. I can extract that to a separate PR; if another of my PRs is likely to go in earlier, I'll probably move it there.