Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling KindLogValuer log Attr types #22

Merged
merged 1 commit into from
Nov 30, 2023
Merged

handling KindLogValuer log Attr types #22

merged 1 commit into from
Nov 30, 2023

Conversation

OrHayat
Copy link

@OrHayat OrHayat commented Nov 29, 2023

Description

handling slog.LogValuer type

Checklist

  • [ V] Code compiles correctly
  • [V] Created tests which fail without the change (if possible)
  • [ V] All tests passing
  • [ X] Extended the README / documentation, if necessary

handling logvaluer log Attr types according
d4f7583 
to slog recommendation with attr.Value.Resolve
@OrHayat OrHayat changed the title handling logvaluer log Attr types handling KindLogValuer log Attr types Nov 29, 2023
@david-littlefarmer david-littlefarmer merged commit 6ce8e83 into golang-cz:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrHayat @david-littlefarmer