Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
  • Loading branch information
qmuntal and dagood authored Sep 24, 2024
1 parent 321654d commit 89d8700
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 5 additions & 1 deletion params.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func newParamBuilder() (*paramBuilder, error) {
return pb, nil
}

// free frees the builder.
// finalize frees the builder.
func (b *paramBuilder) finalize() {
if b.bld != nil {
b.pinner.Unpin()
Expand All @@ -47,6 +47,10 @@ func (b *paramBuilder) finalize() {
}
}

// check is used internally to enforce invariants and should not be called by users of paramBuilder.
// Returns true if it's ok to add parameters to the builder or build it.
// Returns false if there has been an error while adding a parameter.
// Panics if the paramBuilder has been freed, e.g. if it has already been built.
func (b *paramBuilder) check() bool {
if b.err != nil {
return false
Expand Down
1 change: 0 additions & 1 deletion shims.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ typedef void* GO_DSA_PTR;
typedef void* GO_EVP_KDF_PTR;
typedef void* GO_EVP_KDF_CTX_PTR;


// #include <openssl/md5.h>
typedef void* GO_MD5_CTX_PTR;

Expand Down

0 comments on commit 89d8700

Please sign in to comment.