Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with MapClaims VerifyAudience []string #12

Merged
merged 3 commits into from
May 29, 2021
Merged

Fix issue with MapClaims VerifyAudience []string #12

merged 3 commits into from
May 29, 2021

Commits on May 28, 2021

  1. Fix issue with MapClaims VerifyAudience []string 

    There was an issue in MapClaims's VerifyAudiance where a []string (which
is valid in the spec) would return true (claim is found, or nil) when required
was not set.
It now checks interface types correctly and has tests written

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
    @Waterdrips
    Waterdrips committed May 28, 2021
    Configuration menu
    Copy the full SHA
    deb0ef1 View commit details
    Browse the repository at this point in the history

  2. Keep aud validation constant time compare 

    Keep aud validation using constant time compare by not instantly
returning on a true comparison, keep comparing all options and store
result in a variable

Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
    @Waterdrips
    Waterdrips committed May 28, 2021
    Configuration menu
    Copy the full SHA
    f33cfeb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into waterdrips-fix-cve

    @oxisto
    oxisto committed May 28, 2021
    Configuration menu
    Copy the full SHA
    a25aed7 View commit details
    Browse the repository at this point in the history