Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing (almost) full test matrix in GitHub actions #14

Merged
merged 8 commits into from
May 28, 2021

Conversation

oxisto
Copy link
Collaborator

@oxisto oxisto commented May 28, 2021

Starting with Go 1.7, since this is the lowest version still working, once we merge in #12. We can then gradually move upwards with new PRs.

oxisto added 5 commits May 28, 2021 10:54
Starting with Go 1.7, since this is the lowest version still working, once we merge in #12. We can then gradually move upwards.
@oxisto
Copy link
Collaborator Author

oxisto commented May 28, 2021

Meh, seems GitHub Actions has severe problems without go modules, So I will stick with having Go version with modules on Github Actions and the legacy versions on travis, which we will probably phase out at some point.

@oxisto oxisto changed the title Providing full test matrix in GitHub actions Providing (almost) full test matrix in GitHub actions May 28, 2021
@lggomez
Copy link
Member

lggomez commented May 28, 2021

LGTM, although the minimum would be bumped to 1.13 per #9 in its current state

Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@oxisto oxisto merged commit fb1de35 into master May 28, 2021
@oxisto oxisto deleted the full-test-matrix branch May 28, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants