-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go1.18 to ci pipeline #173
Conversation
.github/workflows/build.yml
Outdated
@@ -25,7 +25,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
go: [1.15, 1.16, 1.17, "1.18.0-rc1"] | |||
go: [1.15, 1.16, 1.17, 1.18] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop 1.15 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump the go.mod
version to Go 1.16 then as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped go.mod to 1.16 minimum, and also updated the GitHub actions to v3 (both checkout and go-setup). Note that stable key was removed, so future tags can be used with semver like normal https://github.com/actions/setup-go/releases/tag/v3.0.0 Also released |
Checking pipeline with upcoming major Go version (1.18rc1)