Revert "feat: port clockskew support (#139)"

[mfridman]

This reverts commit d489c99.

Fix #183

Reason: this is a breaking change within a major version (v4). Users might rely on the public interface and the change in signature may cause issues.

[mfridman]

If this is merged, we'll push a v4.4.1 which contains the revert + retraction directive.

[gustavosbarreto]

In order to maintain backwards compatibility, a ValidWithOptions(...) could be added to the public Interface.

[oxisto]

Even adding a new function will break the interface, as someone who implements their own Claims structure, would need to implement ValidWithOptions as well. I think we are stuck with this new feature until v5 :(

[gustavosbarreto]

Even adding a new function will break the interface, as someone who implements their own Claims structure, would need to implement ValidWithOptions as well. I think we are stuck with this new feature until v5 :(

Right. What you think about creating a new interface to extend Claims?

type Claims interface {
	Valid() bool
}

type ClaimsExtended interface {
	Claims
	ValidWithOptions() bool
}

type RegisteredClaims struct {
}

func (r *RegisteredClaims) Valid() bool {
	fmt.Println("RegisteredClaims::Valid")
	return true
}

type RegisteredClaimsExtended struct {
	RegisteredClaims
}

func (r *RegisteredClaimsExtended) ValidWithOptions() bool {
	fmt.Println("RegisteredClaimsExtended::ValidWithOptions")
	return true
}

// call function accordingly to interface type (https://github.com/golang-jwt/jwt/blob/1096e506e671d6d6fe134cc997bbd475937392c8/parser.go#L87)
func Verify(claims Claims) bool {
        // is this claims extended?
	if claimsExt, ok := claims.(ClaimsExtended); ok {
		return claimsExt.ValidWithOptions()
	}

	return claims.Valid()
}

func main() {
	claims := &RegisteredClaims{}
	fmt.Println(Verify(claims))

	claimsExt := &RegisteredClaimsExtended{}
	fmt.Println(Verify(claimsExt))
}