Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use sort.Slice #663

Merged
merged 1 commit into from
Dec 7, 2021
Merged

refactor: use sort.Slice #663

merged 1 commit into from
Dec 7, 2021

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Dec 7, 2021

Since the supported Go version is 1.16 and 1.17 we can use the simpler sort.Slice interface.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1548222039

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 57.8%
Changes Missing Coverage Covered Lines Changed/Added Lines %
source/migration.go 0 4 0.0%
Totals Coverage Status
Change from base Build 1497266502: 0.06%
Covered Lines: 3731
Relevant Lines: 6455
💛 - Coveralls

dhui
dhui approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@dhui dhui merged commit efbef2a into golang-migrate:master Dec 7, 2021
@suzaku suzaku deleted the refacotring branch December 7, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suzaku @coveralls @dhui