Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go-sqlite3 to v1.14.10 #686

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Bump go-sqlite3 to v1.14.10 #686

merged 1 commit into from
Jan 12, 2022

Conversation

pankona
Copy link
Contributor

@pankona pankona commented Jan 12, 2022

Bump go-sqlite3 to v1.14.10 by following command

go get github.com/mattn/go-sqlite3@v1.14.10
go mod tidy

This will resolve #683

@pankona
Copy link
Contributor Author

pankona commented Jan 12, 2022

Hi, maintainer

This is my first contribution to this project. If there's something wrong with my submit, please don't hesitate to say anything to me. Thanks in advance! 💪

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1685816003

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.8%
Totals Coverage Status
Change from base Build 1595125260: 0.0%
Covered Lines: 3731
Relevant Lines: 6455
💛 - Coveralls

@cdamoc90poe
Copy link
Contributor

Thanks for the help! 👍

dhui
dhui approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@dhui dhui merged commit 3e43c42 into golang-migrate:master Jan 12, 2022
@pankona pankona deleted the bump-sqlite3-to-1-14-10 branch January 13, 2022 01:01
@pankona
Copy link
Contributor Author

pankona commented Jan 13, 2022

@cdamoc90poe @dhui

Thank you for your review and merging! 😋
I'm happy if you plan to release a new version that includes this update. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdamoc90poe cdamoc90poe cdamoc90poe approved these changes

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump library version for SQLite to have new features for ALTER TABLE
4 participants
@pankona @coveralls @cdamoc90poe @dhui