Skip to content

chore(options): update default capacity as zero #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2023
Merged

chore(options): update default capacity as zero #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c28a12
chore(options): update default capacity as zero
appleboy Jan 22, 2023
dda7b8a
chore: update default consumer.
appleboy Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func (s *Consumer) Queue(task core.QueuedMessage) error { //nolint:stylecheck
if atomic.LoadInt32(&s.stopFlag) == 1 {
return ErrQueueShutdown
}
if s.count >= s.capacity {
if s.capacity > 0 && s.count >= s.capacity {
return errMaxCapacity
}

Expand Down
4 changes: 2 additions & 2 deletions options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

var (
defaultQueueSize = 4096
defaultCapacity = 0
defaultWorkerCount = runtime.NumCPU()
defaultNewLogger = NewLogger()
defaultFn = func(context.Context, core.QueuedMessage) error { return nil }
Expand Down Expand Up @@ -87,7 +87,7 @@ type Options struct {
func NewOptions(opts ...Option) *Options {
o := &Options{
workerCount: defaultWorkerCount,
queueSize: defaultQueueSize,
queueSize: defaultCapacity,
logger: defaultNewLogger,
worker: nil,
fn: defaultFn,
Expand Down