chore(queue): don't allocate new message #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo-Yi.Wu <appleboy.tw@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 89.42% 89.44% +0.02%
==========================================
Files 7 7
Lines 397 398 +1
==========================================
+ Hits 355 356 +1
Misses 33 33
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
appleboy
changed the title
appleboy
added a commit
that referenced
this pull request
Jan 29, 2023
```sh Run go test -v -run=^$ -count 5 -benchmem -bench . ./... goos: darwin goarch: amd64 pkg: github.com/golang-queue/queue cpu: Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz BenchmarkQueue BenchmarkQueue-3 2442654 498.4 ns/op 270 B/op 4 allocs/op BenchmarkQueue-3 2472348 504.0 ns/op 270 B/op 4 allocs/op BenchmarkQueue-3 2351935 514.6 ns/op 273 B/op 4 allocs/op BenchmarkQueue-3 2384654 517.1 ns/op 272 B/op 4 allocs/op BenchmarkQueue-3 2268847 527.1 ns/op 275 B/op 4 allocs/op ``` ```sh 54s Run go test -v -run=^$ -count 5 -benchmem -bench . ./... goos: darwin goarch: amd64 pkg: github.com/golang-queue/queue cpu: Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz BenchmarkQueue BenchmarkQueue-3 3307142 390.1 ns/op 192 B/op 3 allocs/op BenchmarkQueue-3 3353919 393.2 ns/op 192 B/op 3 allocs/op BenchmarkQueue-3 3142076 397.9 ns/op 194 B/op 3 allocs/op BenchmarkQueue-3 3212948 390.7 ns/op 193 B/op 3 allocs/op BenchmarkQueue-3 3259310 367.6 ns/op 193 B/op 3 allocs/op ``` ```sh $ benchstat a.txt b.txt name old time/op new time/op delta Queue-3 512ns ± 3% 388ns ± 5% -24.27% (p=0.008 n=5+5) name old alloc/op new alloc/op delta Queue-3 272B ± 1% 193B ± 1% -29.12% (p=0.008 n=5+5) name old allocs/op new allocs/op delta Queue-3 4.00 ± 0% 3.00 ± 0% -25.00% (p=0.008 n=5+5) ``` Signed-off-by: Bo-Yi.Wu <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
After
Result
Signed-off-by: Bo-Yi.Wu appleboy.tw@gmail.com