Skip to content

fix(worker): don't start request task #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2022
Merged

fix(worker): don't start request task #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a714b30
fix(worker): don't start request task
appleboy Apr 3, 2022
2320d46
fix: test
appleboy Apr 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,11 @@ func TestNewPoolWithQueueTask(t *testing.T) {
p.Release()
assert.Equal(t, 0, p.BusyWorkers())
}

func TestPoolNumber(t *testing.T) {
p := NewPool(0)
p.Start()
// shutdown all, and now running worker is 0
p.Release()
assert.Equal(t, 0, p.BusyWorkers())
}
3 changes: 3 additions & 0 deletions queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ func NewQueue(opts ...Option) (*Queue, error) {

// Start to enable all worker
func (q *Queue) Start() {
if q.workerCount == 0 {
return
}
q.routineGroup.Run(func() {
q.start()
})
Expand Down