cmd/relui: register tweet workflow definitions

Define an external service configuration for tasks. Its starting point
has tasks running in dry-run mode. Adjust the site header accordingly,
so humans can refer to it to know what to expect from workflows.

Use this external service configuration to register twitter workflows.

After go.dev/issue/51122 is resolved and cmd/relui in the production
environment has access to secret credentials, we can flip the switch
so it starts posting tweets at twitter.com/golang.

Fixes golang/go#47402.

Change-Id: Icccd94518fd7bf39052f67ba1be4db3e42d3d686
Reviewed-on: https://go-review.googlesource.com/c/build/+/385294
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>

Author: dmitshur

cmd/relui/main.go

@@ -14,6 +14,7 @@ import (
 	"github.com/jackc/pgx/v4/pgxpool"
 	"golang.org/x/build/internal/https"
 	"golang.org/x/build/internal/relui"
+	"golang.org/x/build/internal/task"
 )
 
 var (
@@ -39,7 +40,25 @@ func main() {
 		}
 		return
 	}
+
+	// Define the site header and external service configuration.
+	// The site header communicates to humans what will happen
+	// when workflows run.
+	// Keep these appropriately in sync.
+	var (
+		siteHeader = relui.SiteHeader{
+			Title:    "Go Releases (work in progress)",
+			CSSClass: "Site-header--workInProgress",
+		}
+		extCfg = task.ExternalConfig{
+			// TODO(go.dev/issue/51122): Once secrets are available from prod deployment and we're ready, pass them here.
+			// TODO(go.dev/issue/51150): When twitter client creation is factored out from task package, update code here.
+			DryRun: true,
+		}
+	)
+
 	dh := relui.NewDefinitionHolder()
+	relui.RegisterTweetDefinitions(dh, extCfg)
 	db, err := pgxpool.Connect(ctx, *pgConnect)
 	if err != nil {
 		log.Fatal(err)
@@ -57,7 +76,7 @@ func main() {
 			log.Fatalf("url.Parse(%q) = %v, %v", *baseURL, base, err)
 		}
 	}
-	s := relui.NewServer(db, w, base, relui.SiteHeader{Title: "Go Releases"})
+	s := relui.NewServer(db, w, base, siteHeader)
 	if err != nil {
 		log.Fatalf("relui.NewServer() = %v", err)
 	}

internal/relui/static/styles.css

@@ -42,9 +42,15 @@ h6 {
   flex: none;
 }
 .Header {
+  padding: 0.625rem;
+}
+.Site-header--production .Header {
   background: #e0ebf5;
   color: #375eab;
-  padding: 0.625rem;
+}
+.Site-header--workInProgress .Header {
+  background: #d6d6d6;
+  color: #171d27;
 }
 .Header-title {
   font-size: 1.5rem;

internal/relui/web.go

@@ -221,7 +221,10 @@ func (s *Server) createWorkflowHandler(w http.ResponseWriter, r *http.Request) {
 	params := make(map[string]string)
 	for _, n := range d.ParameterNames() {
 		params[n] = r.FormValue(fmt.Sprintf("workflow.params.%s", n))
-		if params[n] == "" {
+
+		// TODO(go.dev/issue/51191): Create a better mechanism for storing parameter metadata.
+		requiredParam := !strings.HasSuffix(n, " (optional)")
+		if requiredParam && params[n] == "" {
 			http.Error(w, http.StatusText(http.StatusBadRequest), http.StatusBadRequest)
 			return
 		}

internal/relui/workflows.go

@@ -7,6 +7,7 @@ package relui
 import (
 	"sync"
 
+	"golang.org/x/build/internal/task"
 	"golang.org/x/build/internal/workflow"
 )
 
@@ -54,6 +55,39 @@ func (h *DefinitionHolder) Definitions() map[string]*workflow.Definition {
 	return defs
 }
 
+// RegisterTweetDefinitions registers workflow definitions involving tweeting
+// onto h, using e for the external service configuration.
+func RegisterTweetDefinitions(h *DefinitionHolder, e task.ExternalConfig) {
+	{
+		wd := workflow.New()
+		wd.Output("TweetURL", wd.Task("tweet-minor", func(ctx *workflow.TaskContext, v1, v2, sec, ann string) (string, error) {
+			return task.TweetMinorRelease(ctx, task.ReleaseTweet{Version: v1, SecondaryVersion: v2, Security: sec, Announcement: ann}, e)
+		}, wd.Parameter("Version"), wd.Parameter("SecondaryVersion"), wd.Parameter("Security (optional)"), wd.Parameter("Announcement")))
+		h.RegisterDefinition("tweet-minor", wd)
+	}
+	{
+		wd := workflow.New()
+		wd.Output("TweetURL", wd.Task("tweet-beta", func(ctx *workflow.TaskContext, v, sec, ann string) (string, error) {
+			return task.TweetBetaRelease(ctx, task.ReleaseTweet{Version: v, Security: sec, Announcement: ann}, e)
+		}, wd.Parameter("Version"), wd.Parameter("Security (optional)"), wd.Parameter("Announcement")))
+		h.RegisterDefinition("tweet-beta", wd)
+	}
+	{
+		wd := workflow.New()
+		wd.Output("TweetURL", wd.Task("tweet-rc", func(ctx *workflow.TaskContext, v, sec, ann string) (string, error) {
+			return task.TweetRCRelease(ctx, task.ReleaseTweet{Version: v, Security: sec, Announcement: ann}, e)
+		}, wd.Parameter("Version"), wd.Parameter("Security (optional)"), wd.Parameter("Announcement")))
+		h.RegisterDefinition("tweet-rc", wd)
+	}
+	{
+		wd := workflow.New()
+		wd.Output("TweetURL", wd.Task("tweet-major", func(ctx *workflow.TaskContext, v, sec string) (string, error) {
+			return task.TweetMajorRelease(ctx, task.ReleaseTweet{Version: v, Security: sec}, e)
+		}, wd.Parameter("Version"), wd.Parameter("Security (optional)")))
+		h.RegisterDefinition("tweet-major", wd)
+	}
+}
+
 // newEchoWorkflow returns a runnable workflow.Definition for
 // development.
 func newEchoWorkflow() *workflow.Definition {