Skip to content

x/build/cmd/relui: create tweet for a minor release #47402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toothrot opened this issue Jul 26, 2021 · 5 comments
Closed

x/build/cmd/relui: create tweet for a minor release #47402

toothrot opened this issue Jul 26, 2021 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

Inside of a relui workflow, you should be able to start a step called Tweet Release Announcement, which requires the following information:

current version released: 1.16.2
new old version: 1.15.10
GOOS/GOARCH for image: linux/amd64
filesize for image: from golang.org/dl API?

After the task is completed, there should be a link called Create Tweet with the tweet text prepopulated as per: https://play.golang.org/p/AomPsnwSG9t, as well as a rendering of the image at https://play.golang.org/p/no9H86XIi0m
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 26, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jul 26, 2021
@dmitshur dmitshur mentioned this issue Jul 26, 2021
Closed
@cagedmantis cagedmantis added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 27, 2021
@abderrahmaneMustapha
Copy link

can i start working on this , i want to help ???

@toothrot toothrot changed the title x/build/cmd/relui: populate draft tweet dialog for a minor release x/build/cmd/relui: create tweet for a minor release Nov 23, 2021
@dmitshur
Copy link
Member

dmitshur commented Feb 1, 2022

Thanks for offering help Toumi! This issue tracks a part of a larger ongoing work and has an assignee, so there isn't a good opportunity here at this time.

Heschi, if you don't mind, I'll send a CL for this as a way of making more incremental progress on #47405. I've made a staging twitter account that I want to test this with first.

@dmitshur dmitshur self-assigned this Feb 1, 2022
@dmitshur dmitshur mentioned this issue Feb 3, 2022
Open
3 tasks
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/382935 mentions this issue: internal/task: accept secrets explicitly via ExternalConfig struct

@dmitshur dmitshur mentioned this issue Feb 9, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/385294 mentions this issue: cmd/relui: register tweet workflow definitions (in dry-run mode only)

gopherbot pushed a commit to golang/build that referenced this issue Feb 16, 2022
@dmitshur
internal/task: accept secrets explicitly via ExternalConfig struct
c1df24b 
Previously, the tweet tasks fetched Twitter API credentials implicitly
from the environment, and a dryRun bool parameter was used to disable
the task from actually posting a tweet (useful for running tests).

This doesn't scale well to being able to supply different credentials,
which is needed to be able to run the task in a staging environment,
using a staging/test set of credentials.

Create an ExternalConfig struct for providing secrets for external
services that tasks need to interact with, making this more explicit.

This will be used by relui in its upcoming "create tweet" workflows.

Update the MailDLCL task analogously to accept the new ExternalConfig
parameter, making it more testable and dry-run-capable in the process.

Also switch to using *workflow.TaskContext (pointer, not value),
since that's what the x/build/internal/workflow package expects.

For golang/go#47402.
Updates golang/go#47405.

Change-Id: I40f0144a57ca0031840fbd1303ab56ac3fefc6c6
Reviewed-on: https://go-review.googlesource.com/c/build/+/382935
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/387274 mentions this issue: cmd/relui: fetch Twitter API secret in production deployment

gopherbot pushed a commit to golang/build that referenced this issue Feb 25, 2022
@dmitshur
cmd/relui: fetch Twitter API secret in production deployment
e91cc72 
Use flag code from CL 386054 to define a -twitter-api-secret flag.
In the production deployment, configure it to fetch the Twitter API
credentials for making tweets at twitter.com/golang, and reconfigure
the site header accordingly.

Tested locally via "secret:go-dashboard-dev/staging-twitter-api-secret"
as the -twitter-api-secret flag value.

For golang/go#47402.
Fixes golang/go#51122.

Change-Id: Ib2fcf5cd9add14f954cac4eddab3d6fa6032eb02
Reviewed-on: https://go-review.googlesource.com/c/build/+/387274
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alex Rakoczy <alex@golang.org>
@rsc rsc unassigned dmitshur and heschi Jun 23, 2022
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@toothrot @cagedmantis @dmitshur @gopherbot @heschi @abderrahmaneMustapha