Skip to content

Commit

Permalink
buildlet: increase timeout period for client
Browse files Browse the repository at this point in the history
The a1.metal instances take about four minutes to become available
before beginning to boot the Windows ARM64 VM. This means we need
somewhere between five and ten minutes before we can first connect to
the buildlet.

It's possible that other instances are faster to boot, but this is
currently the most economical choice.

For golang/go#42604

Change-Id: Ib76944307c9ad28fd1adca0dc54f3fbeaabfffa0
Reviewed-on: https://go-review.googlesource.com/c/build/+/322654
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
  • Loading branch information
toothrot committed May 26, 2021
1 parent 98da949 commit f2096ad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions buildlet/buildlet.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ type VMOpts struct {
// it can connect with the endpoint before returning. The buildletURL is in the form of:
// "https://<ip>". The ipPort field is in the form of "<ip>:<port>". The function
// will attempt to connect to the buildlet for the lesser of: the default timeout period
// (5 minutes) or the timeout set in the passed in context.
// (10 minutes) or the timeout set in the passed in context.
func buildletClient(ctx context.Context, buildletURL, ipPort string, opts *VMOpts) (*Client, error) {
ctx, cancel := context.WithTimeout(ctx, 5*time.Minute)
ctx, cancel := context.WithTimeout(ctx, 10*time.Minute)
defer cancel()
try := 0
for !opts.SkipEndpointVerification {
Expand Down

0 comments on commit f2096ad

Please sign in to comment.