Skip to content

dashboard: increase GO_TEST_TIMEOUT_SCALE for dragonfly builders #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Apr 29, 2021

This sets the GO_TEST_TIMEOUT_SCALE=2 for dragonfly builders in order
to try to solve intermittent test failures.

For golang/go#45215.
For golang/go#34034.
Fixes golang/go#45216.

@gopherbot
Copy link
Contributor

This PR (HEAD: c0fea84) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/315329 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@tuxillo tuxillo force-pushed the dfly-test-timescale branch from c0fea84 to d79ffc5 Compare April 30, 2021 00:30
@gopherbot
Copy link
Contributor

This PR (HEAD: d79ffc5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/315329 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

This sets the GO_TEST_TIMEOUT_SCALE=2 for dragonfly builders in order
to try to solve intermittent test failures.

For golang/go#45215.
For golang/go#34034.
Fixes golang/go#45216.
@tuxillo tuxillo force-pushed the dfly-test-timescale branch from d79ffc5 to 9b4fb80 Compare April 30, 2021 13:17
@gopherbot
Copy link
Contributor

This PR (HEAD: 9b4fb80) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/315329 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Antonio Huete Jimenez:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Antonio Huete Jimenez:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carlos Amedee:

Patch Set 4: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 4: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 4: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carlos Amedee:

Patch Set 4: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/315329.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 30, 2021
This sets the GO_TEST_TIMEOUT_SCALE=2 for dragonfly builders in order
to try to solve intermittent test failures.

For golang/go#45215.
For golang/go#34034.
Fixes golang/go#45216.

Change-Id: I81dae533c137ff1903bf6b1a52cf9752e8921b7c
GitHub-Last-Rev: 9b4fb80
GitHub-Pull-Request: #35
Reviewed-on: https://go-review.googlesource.com/c/build/+/315329
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/315329 has been merged.

@gopherbot gopherbot closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/build: dragonfly-amd64 builders may need a longer TEST_TIMEOUT_SCALE
2 participants