Skip to content

cmd/racebuild: add linux/s390x support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cmd/racebuild: add linux/s390x support #37

wants to merge 1 commit into from

Conversation

iii-i
Copy link
Contributor

@iii-i iii-i commented Jul 22, 2021

LLVM has SystemZ ThreadSanitizer support now [1], this patch adds
support for building race_linux_s390x.syso from it.

[1] https://reviews.llvm.org/D105629

@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 91536ba) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/336511 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

@iii-i
cmd/racebuild: add linux/s390x support
aa29516 
LLVM has SystemZ ThreadSanitizer support now [1], this patch adds
support for building race_linux_s390x.syso from it.

[1] https://reviews.llvm.org/D105629

Change-Id: Idf72fa9445a142cee09a172b5d074da44369f38c
GitHub-Last-Rev: 91536ba
GitHub-Pull-Request: golang#37
@gopherbot
Copy link
Contributor

Message from Ilya Leoshkevich:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: aa29516) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/336511 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ilya Leoshkevich:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

@dmitshur dmitshur mentioned this pull request Nov 8, 2021
Open
@gopherbot
Copy link
Contributor

Message from Keith Randall:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 2: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cherry Mui:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/336511.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 31, 2022
@iii-i @randall77
cmd/racebuild: add linux/s390x support
d652ff4 
LLVM has SystemZ ThreadSanitizer support now [1], this patch adds
support for building race_linux_s390x.syso from it.

[1] https://reviews.llvm.org/D105629

Change-Id: Idf72fa9445a142cee09a172b5d074da44369f38c
GitHub-Last-Rev: aa29516
GitHub-Pull-Request: #37
Reviewed-on: https://go-review.googlesource.com/c/build/+/336511
Reviewed-by: Keith Randall <khr@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/336511 has been merged.

@gopherbot gopherbot closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iii-i @gopherbot