Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Conversation

@AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Aug 28, 2017

No description provided.

@AlekSi AlekSi requested a review from sdboyer as a code owner August 28, 2017 19:19
- your repo will be bigger, potentially a lot bigger
- PR diffs are more annoying
- Your repo will be bigger, potentially a lot bigger.
- PR diffs are more annoying (but files in `vendor/` are [hidden by default](https://github.com/github/linguist/blob/v5.2.0/lib/linguist/generated.rb#L328) on Github).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify that? [hidden by default in Github]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example: https://github.com/percona/mysqld_exporter/pull/6/files Notice that vendor/github.com/percona/exporter_shared is hidden by default.

Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as-is

@sdboyer sdboyer merged commit 1963157 into golang:master Sep 5, 2017
@AlekSi AlekSi deleted the patch-1 branch September 6, 2017 10:46
@ibrasho ibrasho added the docs label Sep 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants