This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Allow transitive constraints #1735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test relied upon constraints NOT being applied transitively. The other is commented out because it was broken by supporting transitive constraints without detecting constraints applied to a package that is not a descendent. This test must be fixed in the follow-up PR to support detecting and ignoring stale constraints.
Verify that transitive constraints are properly popped during a backtrack
carolynvs
force-pushed
the
allow-transitive-constraints
branch
from
5913ce3
to
8ef6f01
Compare
|
Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split up my original PR (#1489) for supporting transitive constraints into the main fix (this). I will follow up later once this is merged with logic to ignore "stale constraints" since that part was wrong in my original PR.
TODO:
Once the logic of the PR is approved, I'll:
Closes #1124