This repository was archived by the owner on Sep 9, 2020. It is now read-only.
JSON output #196
Merged
JSON output #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groob
reviewed
Feb 2, 2017
cmd/dep/status.go
Outdated
| modified bool | ||
| } | ||
|
|
||
| type Outputter interface { |
There was a problem hiding this comment.
I know this is in package main, but the interface should be private.
cmd/dep/status.go
Outdated
| defer sm.Release() | ||
|
|
||
| var out Outputter | ||
| if cmd.detailed { |
There was a problem hiding this comment.
use a switch to set the Outputter instead of all the ifs and elses.
cmd/dep/status.go
Outdated
| } | ||
|
|
||
| func (out *jsonOutput) MissingFooter() { | ||
| json.NewEncoder(os.Stdout).Encode(out.missing) |
There was a problem hiding this comment.
should be out.w instead of os.Stdout?
|
|
||
| type jsonOutput struct { | ||
| w io.Writer | ||
| basic []*BasicStatus |
There was a problem hiding this comment.
Do the two status slices need to be pointers?
There was a problem hiding this comment.
Yes, avoiding copies of marshal
|
@groob Thanks for your review. |
|
Sorry for the delay on this - merging! |
krisnova
pushed a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
[WIP] Refactor sourceMgr
This was referenced Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement for
-json