This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps/solver - Remove SolveParameters.Trace #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone with access re-run the failed CI? It appears to be an unrelated arbitrary timing error ( |
|
Closed/Opened to re-trigger CI. |
|
OK yeah, I looked through. Whatever weird memories I have of needing that extra flag parameter do not seem to hold up. Thanks 😄 |
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
gps/solver - Remove SolveParameters.Trace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a simplification with no effect on program behavior.
Originally discussed here: #525 (comment)
The
Tracefield looked like a switch to turn on trace logging, which required a nil validation check onTraceLogger. However, nil checking the logger is the actual mechanism that triggers logging internally, and the logger was passed along even ifTrace==false, soTracewas really only a switch to turn on a nil check. All (7) usages setTraceLoggerto the result oflog.New()which is never nil, so the validation was not necessary, and omitting it does not otherwise change program behavior.