internal/version: simplify versionArchiveURL #2
Conversation
versionArchiveURL always return nil error. It's unexported, so it's easy to simplify it. If it needs to return an error in the future, it can be changed accordingly at that time. Also declare goURL just before use, rather than too early.
googlebot
added
the
cla: yes
|
This PR (HEAD: a609f1c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/dl/+/134435 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit User 22285: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/134435. |
|
Message from Gerrit User 6005: Patch Set 1: Run-TryBot+1 Testing to see what happens if I run a trybot here. Please don’t reply on this GitHub thread. Visit golang.org/cl/134435. |
|
Message from Gerrit User 5976: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=1b784bc6 Please don’t reply on this GitHub thread. Visit golang.org/cl/134435. |
|
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/134435. |
versionArchiveURL always return nil error. It's unexported, so it's easy to simplify it. If it needs to return an error in the future, it can be changed accordingly at that time. Also move goURL declaration just before use, rather than earlier. Change-Id: I7f16e42b35852cb7bfb5b854e8be7a468e7efdde GitHub-Last-Rev: a609f1c GitHub-Pull-Request: #2 Reviewed-on: https://go-review.googlesource.com/134435 Reviewed-by: Andrew Bonventre <andybons@golang.org>
|
This PR is being closed because golang.org/cl/134435 has been merged. |
versionArchiveURL always return nil error. It's unexported, so it's
easy to simplify it. If it needs to return an error in the future,
it can be changed accordingly at that time.
Also move goURL declaration just before use, rather than earlier.