Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mz unicode #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Mz unicode #13

wants to merge 3 commits into from

Conversation

misak113
Copy link

@misak113 misak113 commented Jan 3, 2021

Add missing XK ISO Level 3 shift non unicode char in x11key map

  • The most appropriate description here: https://unix.stackexchange.com/a/55154/440266
  • Right Alt ~ AltGr ~ ISO level 3 shift (but just for back compatibility)
  • in new sense the SwitchMode is replaced by XK_ISO_Group_Shift and aliases in some languages (keyboard layouts)

Add missing methods descriptions

* the condition was never met because rune is usually unsigned int
* the logical result of checking whether unshifted key rune is ASCII is range from 0 to 0x80
* The most appropriate description here: https://unix.stackexchange.com/a/55154/440266
* Right Alt ~ AltGr ~ ISO level 3 shift (but just for back compatibility)
* in new sense the SwitchMode is replaced by XK_ISO_Group_Shift and aliases in some languages (keyboard layouts)
* adjust package comments to match golint
@google-cla google-cla bot added the cla: yes label Jan 3, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 5e9556e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/281253 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants