Skip to content

Commit

Permalink
cmd/go: disable TestNoteReading on solaris, linux/ppc64le
Browse files Browse the repository at this point in the history
Update #11184 (linux/ppc64).
Filed #12178 (solaris) for Go 1.6.

Change-Id: I9e3a456aaccb49590ad4e14b53ddfefca5b0801c
Reviewed-on: https://go-review.googlesource.com/13679
Reviewed-by: Russ Cox <rsc@golang.org>
  • Loading branch information
rsc committed Aug 18, 2015
1 parent f68d1df commit 92c984e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/cmd/go/note_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
package main_test

import (
"cmd/go"
main "cmd/go"
"runtime"
"testing"
)
Expand All @@ -24,11 +24,18 @@ func TestNoteReading(t *testing.T) {
t.Fatalf("buildID in hello binary = %q, want %q", id, buildID)
}

if runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le" {
t.Logf("skipping - golang.org/issue/11184")
}

switch runtime.GOOS {
case "plan9":
// no external linking
t.Logf("no external linking - skipping linkmode=external test")

case "solaris":
t.Logf("skipping - golang.org/issue/12178")

default:
tg.run("build", "-ldflags", "-buildid="+buildID+" -linkmode=external", "-o", tg.path("hello.exe"), tg.path("hello.go"))
id, err := main.ReadBuildIDFromBinary(tg.path("hello.exe"))
Expand Down

0 comments on commit 92c984e

Please sign in to comment.