Skip to content

Commit

Permalink
cmd/go: remove TestScript/get_unicode and an internal get test case
Browse files Browse the repository at this point in the history
That test tested that import paths with non-ASCII unicode paths
were allowed by the Go command. Remove this test case because
golang.org/cl/251878 removes that support.

Also rewrite a test case in TestRepoRootForImportPath in the test
for cmd/go/internal/get to reflect that unicode directory names are now
disallowed.

Updates #29101

Change-Id: I669e220facd04fc82ccd05dd08e8f1ff4d48b1fd
Reviewed-on: https://go-review.googlesource.com/c/go/+/252297
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
  • Loading branch information
matloob committed Sep 1, 2020
1 parent afa150c commit 971203c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 45 deletions.
7 changes: 2 additions & 5 deletions src/cmd/go/internal/get/vcs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,10 @@ func TestRepoRootForImportPath(t *testing.T) {
Repo: "https://github.com/golang/groupcache",
},
},
// Unicode letters in directories (issue 18660).
// Unicode letters in directories are not valid.
{
"github.com/user/unicode/испытание",
&RepoRoot{
vcs: vcsGit,
Repo: "https://github.com/user/unicode",
},
nil,
},
// IBM DevOps Services tests
{
Expand Down
40 changes: 0 additions & 40 deletions src/cmd/go/testdata/script/get_unicode.txt

This file was deleted.

0 comments on commit 971203c

Please sign in to comment.