Skip to content

Commit

Permalink
sort: cut 140 seconds off race build tests
Browse files Browse the repository at this point in the history
No coverage is gained by running the 1e6 versions of the test over the
1e4 versions. It just adds 140 seconds of race overhead time.

Updates #17104

Change-Id: I41408aedae34a8b1a148eebdda20269cdefffba3
Reviewed-on: https://go-review.googlesource.com/29159
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
  • Loading branch information
bradfitz committed Sep 14, 2016
1 parent 83676b9 commit 983e2fd
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/sort/sort_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ package sort_test

import (
"fmt"
"internal/testenv"
"math"
"math/rand"
. "sort"
"strconv"
stringspkg "strings"
"testing"
)

Expand Down Expand Up @@ -555,6 +557,9 @@ func TestCountStableOps(t *testing.T) { countOps(t, Stable, "Stable") }
func TestCountSortOps(t *testing.T) { countOps(t, Sort, "Sort ") }

func bench(b *testing.B, size int, algo func(Interface), name string) {
if stringspkg.HasSuffix(testenv.Builder(), "-race") && size > 1e4 {
b.Skip("skipping slow benchmark on race builder")
}
b.StopTimer()
data := make(intPairs, size)
x := ^uint32(0)
Expand Down

0 comments on commit 983e2fd

Please sign in to comment.