Skip to content

Commit

Permalink
test: fix ABI mismatch in fixedbugs/issue19507
Browse files Browse the repository at this point in the history
Because run.go doesn't pass the package being compiled to the compiler
via the -p flag, it can't match up the main·f symbol from the
assembler with the "func f" stub in Go, so it doesn't produce the
correct assembly stub.

Fix this by removing the package prefix from the assembly definition.

Alternatively, we could make run.go pass -p to the compiler, but it's
nicer to remove these package prefixes anyway.

Should fix the linux-arm builder, which was broken by the introduction
of function ABIs in CL 147160.

Updates #27539.

Change-Id: Id62b7701e1108a21a5ad48ffdb5dad4356c273a6
Reviewed-on: https://go-review.googlesource.com/c/149483
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
  • Loading branch information
aclements committed Nov 13, 2018
1 parent 0098f8a commit a3c70e2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/fixedbugs/issue19507.dir/div_arm.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

TEXT main·f(SB),0,$0-8
TEXT ·f(SB),0,$0-8
MOVW x+0(FP), R1
MOVW x+4(FP), R2
DIVU R1, R2
Expand Down

0 comments on commit a3c70e2

Please sign in to comment.