Skip to content

Commit

Permalink
time: fix receiver for Time.IsDST method
Browse files Browse the repository at this point in the history
Only methods that modify the time take pointer receivers;
IsDST does not modify it and therefore should not.

For #42102 and #46688.

Change-Id: I4721ef7f4d7572236ae6e4d99a459b9ffb11999e
Reviewed-on: https://go-review.googlesource.com/c/go/+/326789
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
  • Loading branch information
rsc committed Jun 17, 2021
1 parent 881b6ea commit b0355a3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion api/go1.17.txt
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ pkg time, const Layout = "01/02 03:04:05PM '06 -0700"
pkg time, const Layout ideal-string
pkg time, func UnixMicro(int64) Time
pkg time, func UnixMilli(int64) Time
pkg time, method (*Time) IsDST() bool
pkg time, method (Time) IsDST() bool
pkg time, method (Time) GoString() string
pkg time, method (Time) UnixMicro() int64
pkg time, method (Time) UnixMilli() int64
2 changes: 1 addition & 1 deletion src/time/time.go
Original file line number Diff line number Diff line change
Expand Up @@ -1340,7 +1340,7 @@ func UnixMicro(usec int64) Time {
}

// IsDST reports whether the time in the configured location is in Daylight Savings Time.
func (t *Time) IsDST() bool {
func (t Time) IsDST() bool {
_, _, _, _, isDST := t.loc.lookup(t.Unix())
return isDST
}
Expand Down

0 comments on commit b0355a3

Please sign in to comment.