Skip to content

Commit

Permalink
net: disable sendfile on Solaris for now
Browse files Browse the repository at this point in the history
There are reports of corruption. Let's disable it for now (for Go 1.6,
especially) until we can investigate and fix properly.

Update #13892

Change-Id: I557275e5142fe616e8a4f89c00ffafb830eb3b78
Reviewed-on: https://go-review.googlesource.com/18540
Reviewed-by: Dave Cheney <dave@cheney.net>
  • Loading branch information
bradfitz committed Jan 11, 2016
1 parent 3dda43c commit ba593d6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/net/sendfile_solaris.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ const maxSendfileSize int = 4 << 20
//
// if handled == false, sendFile performed no work.
func sendFile(c *netFD, r io.Reader) (written int64, err error, handled bool) {
return // Solaris sendfile is disabled until Issue 13892 is understood and fixed

// Solaris uses 0 as the "until EOF" value. If you pass in more bytes than the
// file contains, it will loop back to the beginning ad nauseam until it's sent
// exactly the number of bytes told to. As such, we need to know exactly how many
Expand Down

0 comments on commit ba593d6

Please sign in to comment.