Skip to content

Commit

Permalink
[release-branch.go1.19] cmd/go: skip TestScript/mod_replace_gopkgin
Browse files Browse the repository at this point in the history
(Until it can be made hermetic.)

The gopkg.in service has had a lot of flakiness lately. Go users in
general are isolated from that flakiness by the Go module mirror
(proxy.golang.org), but this test intentionally bypasses the module
mirror because the mirror itself uses cmd/go to download the module.

In the long term, we can redirect the gopkg.in URL to the local
(in-process) vcweb server added for #27494.

In the meantime, let's skip the test to reduce the impact of upstream
outages.

Fixes #57058.
Updates #54503.

Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea
Reviewed-on: https://go-review.googlesource.com/c/go/+/454503
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit c5f5cb659adda026d01b7fa9bd39b2ad3b58c5bf)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454839
Reviewed-by: Michael Pratt <mpratt@google.com>
  • Loading branch information
Bryan C. Mills authored and prattmic committed Dec 9, 2022
1 parent 1565780 commit c2a2fba
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/cmd/go/testdata/script/mod_replace_gopkgin.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
# even if there is an explicit go.mod file containing the
# gopkg.in path.

skip 'skipping test that depends on an unreliable third-party server; see https://go.dev/issue/54503'
# TODO(#54043): Make this test hermetic and re-enable it.

[short] skip
[!net] skip
[!exec:git] skip
Expand Down

0 comments on commit c2a2fba

Please sign in to comment.