Skip to content

Commit

Permalink
internal/pkgbits: add DerivedInfoNeeded
Browse files Browse the repository at this point in the history
So next CL can use it to remove unnecessary derivedInfo needed field.

Updates #68778

Change-Id: Ia4e0f638beaf4a448fbf10a9aa1bc9425349a5e8
Reviewed-on: https://go-review.googlesource.com/c/go/+/608215
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
  • Loading branch information
cuonglm authored and gopherbot committed Aug 26, 2024
1 parent 2b0a157 commit c586dbb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/internal/pkgbits/pkgbits_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ func TestVersions(t *testing.T) {
{pkgbits.V1, pkgbits.HasInit},
{pkgbits.V0, pkgbits.DerivedFuncInstance},
{pkgbits.V1, pkgbits.DerivedFuncInstance},
{pkgbits.V0, pkgbits.DerivedInfoNeeded},
{pkgbits.V1, pkgbits.DerivedInfoNeeded},
{pkgbits.V2, pkgbits.AliasTypeParamNames},
} {
if !c.v.Has(c.f) {
Expand All @@ -57,6 +59,7 @@ func TestVersions(t *testing.T) {
{pkgbits.V0, pkgbits.Flags},
{pkgbits.V2, pkgbits.HasInit},
{pkgbits.V2, pkgbits.DerivedFuncInstance},
{pkgbits.V2, pkgbits.DerivedInfoNeeded},
{pkgbits.V0, pkgbits.AliasTypeParamNames},
{pkgbits.V1, pkgbits.AliasTypeParamNames},
} {
Expand Down
6 changes: 6 additions & 0 deletions src/internal/pkgbits/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const (
// - remove the legacy "has init" bool from the public root
// - remove obj's "derived func instance" bool
// - add a TypeParamNames field to ObjAlias
// - remove derived info "needed" bool
V2

numVersions = iota
Expand Down Expand Up @@ -56,6 +57,10 @@ const (
// ObjAlias has a list of TypeParamNames.
AliasTypeParamNames

// Deprecated: DerivedInfoNeeded was a bool indicating
// whether a type was a derived type.
DerivedInfoNeeded

numFields = iota
)

Expand All @@ -71,6 +76,7 @@ var introduced = [numFields]Version{
var removed = [numFields]Version{
HasInit: V2,
DerivedFuncInstance: V2,
DerivedInfoNeeded: V2,
}

// Has reports whether field f is present in a bitstream at version v.
Expand Down

0 comments on commit c586dbb

Please sign in to comment.