Skip to content

Commit

Permalink
encoding/json: use SetBytes in UnmarshalReuse benchmark
Browse files Browse the repository at this point in the history
This was the only benchmark missing the SetBytes call, as spotted
earlier by Bryan.

It's not required to make the benchmark useful, but it can still be a
good way to see how its speed is affected by the reduced allocations:

name                  time/op
CodeUnmarshal-8        12.1ms ± 1%
CodeUnmarshalReuse-8   11.4ms ± 1%

name                  speed
CodeUnmarshal-8       161MB/s ± 1%
CodeUnmarshalReuse-8  171MB/s ± 1%

name                  alloc/op
CodeUnmarshal-8        3.28MB ± 0%
CodeUnmarshalReuse-8   1.94MB ± 0%

name                  allocs/op
CodeUnmarshal-8         92.7k ± 0%
CodeUnmarshalReuse-8    77.6k ± 0%

While at it, remove some unnecessary empty lines.

Change-Id: Ib2bd92d5b3237b8f3092e8c6f863dab548fee2f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/170938
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
  • Loading branch information
mvdan committed Apr 5, 2019
1 parent 06cff11 commit cb66462
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion src/encoding/json/bench_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func BenchmarkCodeUnmarshalReuse(b *testing.B) {
}
}
})
// TODO(bcmills): Is there a missing b.SetBytes here?
b.SetBytes(int64(len(codeJSON)))
}

func BenchmarkUnmarshalString(b *testing.B) {
Expand Down
1 change: 0 additions & 1 deletion src/encoding/json/example_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ func ExampleDecoder_Decode_stream() {
// Sam: Go fmt who?
// Ed: Go fmt yourself!
// json.Delim: ]

}

// This example uses RawMessage to delay parsing part of a JSON message.
Expand Down
2 changes: 0 additions & 2 deletions src/encoding/json/stream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ var tokenStreamCases = []tokenStreamCase{
}

func TestDecodeInStream(t *testing.T) {

for ci, tcase := range tokenStreamCases {

dec := NewDecoder(strings.NewReader(tcase.json))
Expand Down Expand Up @@ -401,7 +400,6 @@ func TestDecodeInStream(t *testing.T) {
}
}
}

}

// Test from golang.org/issue/11893
Expand Down

0 comments on commit cb66462

Please sign in to comment.