flag: panic on android/arm64

[karalabe]

Just been cross compiling to various flavors of Android, and hit a bug present on android/arm64 (it works as intended on both android/arm and android/386). The flag package reads os.Args[0] at https://github.com/golang/go/blob/master/src/flag/flag.go#L939, which is not initialized on android/arm64, producing a hard crash.

[karalabe]

After some digging around in the code base, the issue is that the os.Args isn't initialized for android/arm64 when building with buildmode=c-shared.

android/arm64 vs. android/arm

[karalabe]

PTAL https://go-review.googlesource.com/#/c/17782/

[rsc]

Presumably fixed by CL 17782.

[karalabe]

Ah yes, thought it would be auto closed.
On Dec 17, 2015 9:20 AM, "Russ Cox" notifications@github.com wrote:

Presumably fixed by CL 17782.

—
Reply to this email directly or view it on GitHub
#13599 (comment).

[rsc]

It gets auto-closed when the commit message says 'Fixes #13599.' But that got dropped or omitted somehow. :-)