go/types: gotype requires installed packages

[the42]

go1.6 gotype seems to be unaware of vendoring

1. What version of Go are you using (go version)?
   1.6
2. What operating system and processor architecture are you using (go env)?
   GOARCH="amd64"
   GOBIN=""
   GOEXE=""
   GOHOSTARCH="amd64"
   GOHOSTOS="linux"
   GOOS="linux"
   GOPATH="/home/john/src/gocode"
   GORACE=""
   GOROOT="/home/john/opt/go"
   GOTOOLDIR="/home/john/opt/go/pkg/tool/linux_amd64"
   GO15VENDOREXPERIMENT="1"
   CC="gcc"
   GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
   CXX="g++"
   CGO_ENABLED="1"
3. What did you do?
   john@ebola:~/src/gocode/src/github.com/the42/bevaddress$ gotype bevaddress.go

The tree is
john@ebola:~/src/gocode/src/github.com/the42/bevaddress$ tree -d
.
├── Godeps
└── vendor
└── github.com
├── gorilla
│   └── websocket
└── lib
└── pq
└── oid

8 directories

1. What did you expect to see?
   no error (go build works)
2. What did you see instead?
   bevaddress.go:9:2: could not import github.com/gorilla/websocket (can't find import: github.com/the42/bevaddress/vendor/github.com/gorilla/websocket)
   bevaddress.go:10:4: could not import github.com/lib/pq (can't find import: github.com/the42/bevaddress/vendor/github.com/lib/pq)
   bevaddress.go:18:16: undeclared name: websocket

[bcomnes]

@the42 It was recommended to me to run go install or go build -i after vending code or running for the first time. This builds out the vendor code into $GOPATH/pkg/{packagePath}/vendor/... and then gotype stops complaining. I guess its similar to an npm i step.

[the42]

@bcomnes what remains is whether your recommendation is the way it should be or if it's a bug. I think it's a bug.

[griesemer]

Related to #11415. gotype is simply an app that invokes go/types. go/types doesn't build dependencies, it simply type-checks on package and relies on compiled versions of imported packages. If those don't exist (are not installed), go/types cannot find them.

Eventually, go/importer needs to support importing from source.

[bcomnes]

@the42 ¯\_(ツ)_/¯
@griesemer Thanks for the background. 👍