Skip to content

x/net/webdav: DeadPropsHolder interface is not possible to be implemented #15128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
igungor opened this issue Apr 5, 2016 · 1 comment
Closed

Comments

@igungor
Copy link

igungor commented Apr 5, 2016

I'm using go 1.6, x/net/webdav: golang/net@d75b190
goenv: GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/ibrahim" GORACE="" GOROOT="/usr/local/go" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GO15VENDOREXPERIMENT="1" CC="clang" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common" CXX="clang++" CGO_ENABLED="1"

webdav.File implementers can optionally implement webdav.DeadPropsHolder interface.I f you try to implement that interface, you have to use xml.Name as the key to map[xml.Name]webdav.Property, which is an internal package: golang.org/x/net/webdav/internal/xml. You can't reach that package outside of the webdav package.
/CC: @nigeltao

@igungor igungor changed the title x/net/webdav: Can not set DeadProps x/net/webdav: DeadPropsHolder interface is not possible to be implemented Apr 5, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/21635 mentions this issue.

@golang golang locked and limited conversation to collaborators Apr 8, 2017
dt-eric-lefevreardant pushed a commit to DiliTrust/go-webdav that referenced this issue Mar 11, 2025
In particular, the Property and DeadPropsHolder types need to refer to
the standard xml package, not the internal fork, to be usable by other
packages.

Inside the package, the XML marshaling and unmarshaling is still done by
the etc/internal/xml package, and will remain that way until
golang/go#13400 is resolved.

Fixes golang/go#15128.

Change-Id: Ie7e7927d8b30d97d10b1a4a654d774fdf3e7a1e3
Reviewed-on: https://go-review.googlesource.com/21635
Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants