Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/objdump: implement s390x disassembler #15255

Closed
mundaym opened this issue Apr 12, 2016 · 9 comments
Closed

cmd/objdump: implement s390x disassembler #15255

mundaym opened this issue Apr 12, 2016 · 9 comments
Assignees
@srinivas-pokala @Vishwanatha-HD
Labels
arch-s390x Issues solely affecting the s390x architecture. compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@mundaym
Copy link
Member

mundaym commented Apr 12, 2016

Unplanned at the moment.
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/21894 mentions this issue.

@bradfitz bradfitz added this to the Unplanned milestone Apr 12, 2016
gopherbot pushed a commit that referenced this issue Apr 12, 2016
@mundaym @bradfitz
cmd/objdump: skip TestDisasm* on s390x
be7c786 
The disassembler is not yet implemented on s390x.

Updates #15255.

Change-Id: Ibab319c8c087b1a619baa1529398305c1e721877
Reviewed-on: https://go-review.googlesource.com/21894
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@rsc rsc added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 26, 2016
@randall77 randall77 mentioned this issue Feb 17, 2017
Open
@mundaym mundaym added the arch-s390x Issues solely affecting the s390x architecture. label Dec 2, 2020
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
@srinivas-pokala srinivas-pokala self-assigned this Aug 30, 2023
@srinivas-pokala
Copy link
Contributor

@rsc, I am working on disassembler support for linux/s390x

@Vishwanatha-HD Vishwanatha-HD added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Apr 2, 2024
@Vishwanatha-HD Vishwanatha-HD self-assigned this Apr 2, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/575735 mentions this issue: cmd/objdump: implement s390x go disassembler support

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/579977 mentions this issue: cmd/objdump: enable disassembler tests on s390x platform

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/581015 mentions this issue: cmd/vendor/golang.org/x/arch:add s390x disassembler changes

@Vishwanatha-HD
Copy link
Contributor

The s390x disassembler support CL# is (arch repo):
https://go-review.googlesource.com/c/arch/+/575675

@dmitshur dmitshur modified the milestones: Unplanned, Go1.24 Aug 21, 2024
gopherbot pushed a commit that referenced this issue Aug 21, 2024
@srinivas-pokala @gopherbot
cmd/objdump: add s390x GNU disasm support
0d56058 
This CL provides vendor support for s390x disassembler gnu syntax.
go get golang.org/x/arch@master
go mod tidy
go mod vendor

For #15255

Change-Id: Ia75fa515e7ea7d56913a28147c65650a7ab3062c
Reviewed-on: https://go-review.googlesource.com/c/go/+/581015
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Auto-Submit: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bill O'Farrell <billotosyr@gmail.com>
@mknyszek mknyszek moved this to In Progress in Go Compiler / Runtime Aug 21, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/623075 mentions this issue: cmd/objdump: add s390x plan9 disasm support

gopherbot pushed a commit that referenced this issue Nov 6, 2024
@srinivas-pokala @cherrymui
cmd/objdump: add s390x plan9 disasm support
eb29beb 
This CL provides vendor support for s390x disassembler plan9 syntax.

cd $GOROOT/src/cmd
go get golang.org/x/arch@master
go mod tidy
go mod vendor

For #15255

Change-Id: I20c87510a1aee2d1cf2df58feb535974c4c0e3ef
Reviewed-on: https://go-review.googlesource.com/c/go/+/623075
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@srinivas-pokala
Copy link
Contributor

Disassembler support for s390x enabled, hence closing the issue.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Nov 7, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/636519 mentions this issue: _content/doc/go1.24: add objdump updates

gopherbot pushed a commit to golang/website that referenced this issue Dec 16, 2024
@cherrymui
_content/doc/go1.24: add objdump updates
ad6037a 
The objdump tool now supports dissassembly on riscv64, loong64,
and s390x.

Updates golang/go#15255, golang/go#36738.
For golang/go#68545.

Change-Id: I5e913eb27383f42777baac1cd8436a5c6eb629fd
Reviewed-on: https://go-review.googlesource.com/c/website/+/636519
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srinivas-pokala srinivas-pokala

@Vishwanatha-HD Vishwanatha-HD

Labels
arch-s390x Issues solely affecting the s390x architecture. compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Compiler / Runtime
Status: Done
Milestone
Go1.24
Development

No branches or pull requests
7 participants
@bradfitz @rsc @dmitshur @gopherbot @mundaym @srinivas-pokala @Vishwanatha-HD