build: run more buildmode=shared tests

[crawshaw]

#16590 was found very late in the 1.7 cycle and would have been caught much earlier if standard library tests for buildmode=shared were being run somewhere.

[bradfitz]

What's the the environment variable I can set? GO_GCFLAGS=...., GO_LDFLAGS=.... ?

[crawshaw]

I don't think there's an environment variable that will do the job (yet). The standard library needs to be installed with -buildmode=shared, and then the binary built with -linkshared. Those are go binary flags, not compiler/linker flags.

[bradfitz]

Looks like an environment variable already exists: $GO_FLAGS:

make.bash does:

CC=$CC_FOR_TARGET "$GOTOOLDIR"/go_bootstrap install $GO_FLAGS -gcflags "$GO_GCFLAGS" -ldflags "$GO_LDFLAGS" -v std cmd

[mwhudson]

You can't install the standard library linked against itself though.

On 5 August 2016 at 13:10, Brad Fitzpatrick notifications@github.com
wrote:

Looks like an environment variable already exists: $GO_FLAGS:

make.bash does:

CC=$CC_FOR_TARGET "$GOTOOLDIR"/go_bootstrap install $GO_FLAGS -gcflags
"$GO_GCFLAGS" -ldflags "$GO_LDFLAGS" -v std cmd

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#16602 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AApBFqjc5DLyAZpGwGyF45ypqltHaME7ks5qco11gaJpZM4JcnyH
.

[bradfitz]

I don't follow. Tell me what to do and I'll set up builder.

[mwhudson]

Doing "cd src && ./make.bash && go install -buildmode=shared std && cd ../test && go run run.go -linkshared" would be one useful thing. I'm not sure if that's what @crawshaw meant, sorry for hijacking if not.

[rsc]

@crawshaw, what command should the buildmode=shared builder run?

[crawshaw]

Ideally the stdlib tests, against a dynamically linked stdlib:

./make.bash
go install -buildmode=shared std
go test -short -linkshared std

As a bonus, what @mwhudson suggested:

cd ../test && go run run.go -linkshared

This is mostly just adding the -linkshared flag to the usual tests, but cmd/dist has to call go install somewhere first.

[bradfitz]

@quentinmit, any interest in setting up a new builder for this?