Skip to content

net/http: data race writing to req.Header when serving push #18326

New issue
New issue
Closed
Closed
net/http: data race writing to req.Header when serving push#18326
Labels
FrozenDueToAge
Milestone
 
Go1.8
@FiloSottile

Description

@FiloSottile
FiloSottile
opened on Dec 15, 2016

What version of Go are you using (go version)?

go version go1.8beta1 darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/filippo/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.8beta1/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.8beta1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/v8/xdj2snz51sg2m2bnpmwl_91c0000gn/T/go-build410982852=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?

Modified the req.Header map from a Handler invoked by Push.

https://play.golang.org/p/3azPpVRX8f

What did you see instead?

==================
WARNING: DATA RACE
Read at 0x00c42006fdd0 by goroutine 17:
  runtime.mapiterinit()
      /usr/local/Cellar/go/1.8beta1/libexec/src/runtime/hashmap.go:668 +0x0
  net/http.(*http2sorter).Keys()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:2739 +0xb8
  net/http.http2encodeHeaders()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:7604 +0x365
  net/http.(*http2writePushPromise).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:7542 +0x257
  net/http.(*http2serverConn).writeFrameAsync()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3450 +0x58

Previous write at 0x00c42006fdd0 by goroutine 16:
  runtime.mapassign()
      /usr/local/Cellar/go/1.8beta1/libexec/src/runtime/hashmap.go:485 +0x0
  net/textproto.MIMEHeader.Set()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/textproto/header.go:22 +0x7e
  net/http.Header.Set()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/header.go:31 +0x60
  main.main.func2()
      test.go:18 +0x7c
  net/http.HandlerFunc.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1930 +0x51
  net/http.(*ServeMux).ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:2226 +0xa2
  net/http.serverHandler.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:2556 +0xbc
  net/http.initNPNRequest.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:3076 +0x109
  net/http.(*initNPNRequest).ServeHTTP()
      <autogenerated>:310 +0x98
  net/http.(Handler).ServeHTTP-fm()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:4286 +0x64
  net/http.(*http2serverConn).runHandler()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:4566 +0x96

Goroutine 17 (running) created at:
  net/http.(*http2serverConn).startFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3732 +0x33b
  net/http.(*http2serverConn).scheduleFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3823 +0x3e1
  net/http.(*http2serverConn).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3686 +0x76
  net/http.(*http2serverConn).startPush()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5227 +0x33d
  net/http.(*http2serverConn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3533 +0x987
  net/http.(*http2Server).ServeConn()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3170 +0xc82
  net/http.http2ConfigureServer.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3052 +0xe7
  net/http.(*conn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1734 +0x1956

Goroutine 16 (running) created at:
  net/http.(*http2serverConn).startPush.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5213 +0x598
  net/http.(*http2serverConn).startFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3714 +0x3bb
  net/http.(*http2serverConn).scheduleFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3823 +0x3e1
  net/http.(*http2serverConn).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3686 +0x76
  net/http.(*http2serverConn).startPush()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5227 +0x33d
  net/http.(*http2serverConn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3533 +0x987
  net/http.(*http2Server).ServeConn()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3170 +0xc82
  net/http.http2ConfigureServer.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3052 +0xe7
  net/http.(*conn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1734 +0x1956
==================
==================
WARNING: DATA RACE
Read at 0x00c4201f2088 by goroutine 17:
  net/http.http2encodeHeaders()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:7607 +0xdd
  net/http.(*http2writePushPromise).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:7542 +0x257
  net/http.(*http2serverConn).writeFrameAsync()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3450 +0x58

Previous write at 0x00c4201f2088 by goroutine 16:
  net/textproto.MIMEHeader.Set()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/textproto/header.go:22 +0xdf
  net/http.Header.Set()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/header.go:31 +0x60
  main.main.func2()
      test.go:18 +0x7c
  net/http.HandlerFunc.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1930 +0x51
  net/http.(*ServeMux).ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:2226 +0xa2
  net/http.serverHandler.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:2556 +0xbc
  net/http.initNPNRequest.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:3076 +0x109
  net/http.(*initNPNRequest).ServeHTTP()
      <autogenerated>:310 +0x98
  net/http.(Handler).ServeHTTP-fm()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:4286 +0x64
  net/http.(*http2serverConn).runHandler()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:4566 +0x96

Goroutine 17 (running) created at:
  net/http.(*http2serverConn).startFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3732 +0x33b
  net/http.(*http2serverConn).scheduleFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3823 +0x3e1
  net/http.(*http2serverConn).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3686 +0x76
  net/http.(*http2serverConn).startPush()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5227 +0x33d
  net/http.(*http2serverConn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3533 +0x987
  net/http.(*http2Server).ServeConn()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3170 +0xc82
  net/http.http2ConfigureServer.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3052 +0xe7
  net/http.(*conn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1734 +0x1956

Goroutine 16 (running) created at:
  net/http.(*http2serverConn).startPush.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5213 +0x598
  net/http.(*http2serverConn).startFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3714 +0x3bb
  net/http.(*http2serverConn).scheduleFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3823 +0x3e1
  net/http.(*http2serverConn).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3686 +0x76
  net/http.(*http2serverConn).startPush()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5227 +0x33d
  net/http.(*http2serverConn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3533 +0x987
  net/http.(*http2Server).ServeConn()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3170 +0xc82
  net/http.http2ConfigureServer.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3052 +0xe7
  net/http.(*conn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1734 +0x1956
==================
==================
WARNING: DATA RACE
Read at 0x00c4201c21e0 by goroutine 17:
  net/http.http2encodeHeaders()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:7614 +0x17d
  net/http.(*http2writePushPromise).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:7542 +0x257
  net/http.(*http2serverConn).writeFrameAsync()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3450 +0x58

Previous write at 0x00c4201c21e0 by goroutine 16:
  net/textproto.MIMEHeader.Set()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/textproto/header.go:22 +0xae
  net/http.Header.Set()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/header.go:31 +0x60
  main.main.func2()
      test.go:18 +0x7c
  net/http.HandlerFunc.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1930 +0x51
  net/http.(*ServeMux).ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:2226 +0xa2
  net/http.serverHandler.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:2556 +0xbc
  net/http.initNPNRequest.ServeHTTP()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:3076 +0x109
  net/http.(*initNPNRequest).ServeHTTP()
      <autogenerated>:310 +0x98
  net/http.(Handler).ServeHTTP-fm()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:4286 +0x64
  net/http.(*http2serverConn).runHandler()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:4566 +0x96

Goroutine 17 (running) created at:
  net/http.(*http2serverConn).startFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3732 +0x33b
  net/http.(*http2serverConn).scheduleFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3823 +0x3e1
  net/http.(*http2serverConn).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3686 +0x76
  net/http.(*http2serverConn).startPush()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5227 +0x33d
  net/http.(*http2serverConn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3533 +0x987
  net/http.(*http2Server).ServeConn()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3170 +0xc82
  net/http.http2ConfigureServer.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3052 +0xe7
  net/http.(*conn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1734 +0x1956

Goroutine 16 (running) created at:
  net/http.(*http2serverConn).startPush.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5213 +0x598
  net/http.(*http2serverConn).startFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3714 +0x3bb
  net/http.(*http2serverConn).scheduleFrameWrite()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3823 +0x3e1
  net/http.(*http2serverConn).writeFrame()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3686 +0x76
  net/http.(*http2serverConn).startPush()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:5227 +0x33d
  net/http.(*http2serverConn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3533 +0x987
  net/http.(*http2Server).ServeConn()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3170 +0xc82
  net/http.http2ConfigureServer.func1()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/h2_bundle.go:3052 +0xe7
  net/http.(*conn).serve()
      /usr/local/Cellar/go/1.8beta1/libexec/src/net/http/server.go:1734 +0x1956
==================

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAge

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions